[Top] [All Lists]

Re: [PATCH 1/1] XFS: __xfs_get_blocks check pointer to the target device

To: Ramon de Carvalho Valle <ramon@xxxxxxxxxxxxxxxx>
Subject: Re: [PATCH 1/1] XFS: __xfs_get_blocks check pointer to the target device
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Tue, 04 Aug 2009 11:25:52 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, hch@xxxxxx, linux-kernel@xxxxxxxxxxxxxxx, mszeredi@xxxxxxxxxx
In-reply-to: <1249351241.7513.18.camel@logos>
References: <1249329808.7686.26.camel@logos> <20090803214929.GB3167@xxxxxxxxxxxxx> <1249351241.7513.18.camel@logos>
User-agent: Thunderbird (Macintosh/20090605)
Ramon de Carvalho Valle wrote:
> On Mon, 2009-08-03 at 17:49 -0400, Christoph Hellwig wrote:
>> On Mon, Aug 03, 2009 at 05:03:28PM -0300, Ramon de Carvalho Valle wrote:
>>> The __xfs_get_blocks function does not check if the pointer to the target
>>> device is valid before dereferencing it.
>> It should never be zero.  It's set by xfs_imap_to_bmap to either
>> mp->m_ddev_targp which is always allocated, or to mp->m_rtdev_targp
>> which is always allocated if we have a realtime device, and
>> XFS_IS_REALTIME_INODE should only be true in that case.
> While testing XFS code with a modified version of fsfuzzer on SLES 10
> SP3 (Kernel, I came across the following
> Oops:


ahah, useful information that would have been great in the original
patch submission.  :)

> I added a printk() line just before the:
>       bh_result->b_bdev = iomap.iomap_target->bt_bdev;
> and as we can see iomap.iomap_target is NULL.
> My guess is that the XFS_DIFLAG_REALTIME flag is being set incorrectly
> on the xfs inode structure, setting iomapp->iomap_target to the wrong
> device pointer (probably NULL).
> I don't know if this is the best place to add a check, neither if
> returning -XFS_ERROR(EIO) is correct at this point. Maybe doing:
>       if (iomap.iomap_target && omap.iomap_flags & IOMAP_REALTIME)
>               bh_result->b_bdev = iomap.iomap_target->bt_bdev;
> would be a better solution.

Can you test hch's patch w/ your fuzzed image?


<Prev in Thread] Current Thread [Next in Thread>