xfs
[Top] [All Lists]

Re: [PATCH] xfstests: actually hook up 198, make it generic

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: actually hook up 198, make it generic
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Thu, 30 Jul 2009 10:38:23 -0500
Cc: xfs mailing list <xfs@xxxxxxxxxxx>
In-reply-to: <20090730152756.GB27914@xxxxxxxxxxxxx>
References: <4A708FF7.5@xxxxxxxxxxx> <20090730152756.GB27914@xxxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.22 (Macintosh/20090605)
Christoph Hellwig wrote:
> On Wed, Jul 29, 2009 at 01:07:51PM -0500, Eric Sandeen wrote:
>> Not entirely sure how I managed this, but 198 was not in groups
>> so was never run - and wasn't in the makefile, so was never built.
>> Oops.
>>
>> Fix that up, make it a generic test, and move it to the
>> aio-dio-regress subdir.
> 
> Hah, great one.

yeah, I rock!  :/

>>  # This should actually run on anything that supports O_DIRECT + AIO...
>> -_supported_fs xfs
>> +_supported_fs generic
> 
> maybe also remove that comment now that it's generic.

Ok, sure.

>> --- /dev/null
>> +++ b/src/aio-dio-regress/aiodio_sparse2.c
>> @@ -0,0 +1,384 @@
>> +/* gcc -g -Wall -O2 aiodio_sparse.c -o aiodio_sparse -laio */
>> +
>> +/*
>> + * From http://developer.osdl.org/daniel/AIO/TESTS/aiodio_sparse.c
>> + * With patch from https://bugzilla.redhat.com/attachment.cgi?id=142124
>> + * (Bug https://bugzilla.redhat.com/show_bug.cgi?id=217098)
>> + */
> 
> Did we manage to get a proper copyright / license statement for this
> one.

hadn't looked into it; I'll  ping Daniel McNeil who seems to be the
original author ...?

But I'll fix it and worry about the copyright later, since it's already
in ...

-Eric

<Prev in Thread] Current Thread [Next in Thread>