xfs
[Top] [All Lists]

Re: [PATCH] xfstests 219: test fiemap

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests 219: test fiemap
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Sun, 26 Jul 2009 21:48:05 -0500
Cc: Josef Bacik <jbacik@xxxxxxxxxx>, xfs mailing list <xfs@xxxxxxxxxxx>
In-reply-to: <20090718221948.GA22347@xxxxxxxxxxxxx>
References: <4A5F82D8.8080709@xxxxxxxxxxx> <20090718142339.GA20905@xxxxxxxxxxxxx> <4A61F92D.7090708@xxxxxxxxxxx> <20090718221948.GA22347@xxxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.22 (Macintosh/20090605)
Christoph Hellwig wrote:
> On Sat, Jul 18, 2009 at 11:32:45AM -0500, Eric Sandeen wrote:
>> I suppose it'd be nice to have, though in this case the test program
>> also generates all the random patterns and does the checking ... the
>> fiemap calls are a relatively simple part of it ...
>>
>> Using xfs_io would be a bit like saying "xfs_io can already generate all
>> the calls that fsx generates, why not use it instead of a special test
>> program...." IMHO.
> 
> fiemap support in xfs_io would still be useful.  The big difference with
> fsx and co is that the I/O path is quite performance critical even for
> testcases, while for preallocation it's not.

Ok, we can add that.  Another patch.  :)

> But if it makes life a lot easier we can certainly drive these tests
> from a C program.

It's easier in the sense that it's done.  It'd be nice to get some
fiemap coverage & this is a quick route that seems to work.

Thanks,
-Eric

<Prev in Thread] Current Thread [Next in Thread>