xfs
[Top] [All Lists]

Re: [PATCH] xfs_repair: check for null single-block dir buffer pointer i

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfs_repair: check for null single-block dir buffer pointer in phase6
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 25 Jul 2009 11:02:56 -0400
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <4A69C660.9000604@xxxxxxxxxxx>
References: <4A69C660.9000604@xxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Fri, Jul 24, 2009 at 09:34:08AM -0500, Eric Sandeen wrote:
> @@ -2524,7 +2525,7 @@ longform_dir2_entry_check(xfs_mount_t   *mp,
>  
>       if (!dotdot_update) {
>               /* check btree and freespace */
> -             if (isblock) {
> +             if (isblock && bplist[0]) {
>                       xfs_dir2_block_tail_t   *btp;
>                       xfs_dir2_leaf_entry_t   *blp;

This doesn't look quite correct to me.  Now we falls through to the
final else statement when bplist[0] is zeroed.

<Prev in Thread] Current Thread [Next in Thread>