xfs
[Top] [All Lists]

Re: xfstests: nslookup not found

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: xfstests: nslookup not found
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Sun, 19 Jul 2009 17:26:11 -0500
Cc: Christian Kujau <lists@xxxxxxxxxxxxxxx>, linux-xfs@xxxxxxxxxxx
In-reply-to: <20090719182012.GA10936@xxxxxxxxxxxxx>
References: <alpine.DEB.2.01.0907191050010.6439@bogon> <20090719182012.GA10936@xxxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.22 (Macintosh/20090605)
Christoph Hellwig wrote:
> On Sun, Jul 19, 2009 at 10:57:35AM -0700, Christian Kujau wrote:
>> Hi,
>>
>> while trying to run ./check in a current xfstests tree, execution stopped 
>> because "nslookup" was not available. I could've just installed this tool 
>> but I wondered why xfstests, a filesystem testing tool, would need 
>> nslookup at all. Turns out that it's being used in a routine called 
>> "_get_fqdn", which in turn is only called once in ./new, to set a variable 
>> called "owner" and I ask myself: do I really want my FQDN listed in the 
>> testresults, that maybe even get published for analysis? I changed this 
>> whole _get_fqdn thingy to just "uname -n", but I'm eager to know why the 
>> FQDN is crucial here :-)
> 
> It uses it as email address for the test owner.  In these days this
> probably requires hand-editing anyway, but the fqdn is certainly
> a better approximation than uname -n.
> 
> Can you resend a patch that just moves _get_fqdn and the check for
> nslookup from common* into the "new" script?

That'd be great - sounds like the right solution to me; I've run into
this too but never bothered to fix it.  :)

Thanks,
-Eric

<Prev in Thread] Current Thread [Next in Thread>