[Top] [All Lists]

Re: xfstests: nslookup not found

To: Christian Kujau <lists@xxxxxxxxxxxxxxx>
Subject: Re: xfstests: nslookup not found
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 19 Jul 2009 14:20:12 -0400
Cc: linux-xfs@xxxxxxxxxxx
In-reply-to: <alpine.DEB.2.01.0907191050010.6439@bogon>
References: <alpine.DEB.2.01.0907191050010.6439@bogon>
User-agent: Mutt/1.5.18 (2008-05-17)
On Sun, Jul 19, 2009 at 10:57:35AM -0700, Christian Kujau wrote:
> Hi,
> while trying to run ./check in a current xfstests tree, execution stopped 
> because "nslookup" was not available. I could've just installed this tool 
> but I wondered why xfstests, a filesystem testing tool, would need 
> nslookup at all. Turns out that it's being used in a routine called 
> "_get_fqdn", which in turn is only called once in ./new, to set a variable 
> called "owner" and I ask myself: do I really want my FQDN listed in the 
> testresults, that maybe even get published for analysis? I changed this 
> whole _get_fqdn thingy to just "uname -n", but I'm eager to know why the 
> FQDN is crucial here :-)

It uses it as email address for the test owner.  In these days this
probably requires hand-editing anyway, but the fqdn is certainly
a better approximation than uname -n.

Can you resend a patch that just moves _get_fqdn and the check for
nslookup from common* into the "new" script?

<Prev in Thread] Current Thread [Next in Thread>