xfs
[Top] [All Lists]

Re: [PATCH] xfstests 219: test fiemap

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfstests 219: test fiemap
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 18 Jul 2009 18:19:48 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Josef Bacik <jbacik@xxxxxxxxxx>, xfs mailing list <xfs@xxxxxxxxxxx>
In-reply-to: <4A61F92D.7090708@xxxxxxxxxxx>
References: <4A5F82D8.8080709@xxxxxxxxxxx> <20090718142339.GA20905@xxxxxxxxxxxxx> <4A61F92D.7090708@xxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Sat, Jul 18, 2009 at 11:32:45AM -0500, Eric Sandeen wrote:
> I suppose it'd be nice to have, though in this case the test program
> also generates all the random patterns and does the checking ... the
> fiemap calls are a relatively simple part of it ...
> 
> Using xfs_io would be a bit like saying "xfs_io can already generate all
> the calls that fsx generates, why not use it instead of a special test
> program...." IMHO.

fiemap support in xfs_io would still be useful.  The big difference with
fsx and co is that the I/O path is quite performance critical even for
testcases, while for preallocation it's not.

But if it makes life a lot easier we can certainly drive these tests
from a C program.

<Prev in Thread] Current Thread [Next in Thread>