xfs
[Top] [All Lists]

Re: [PATCH] xfstests 219: test fiemap

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests 219: test fiemap
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Sat, 18 Jul 2009 11:32:45 -0500
Cc: Josef Bacik <jbacik@xxxxxxxxxx>, xfs mailing list <xfs@xxxxxxxxxxx>
In-reply-to: <20090718142339.GA20905@xxxxxxxxxxxxx>
References: <4A5F82D8.8080709@xxxxxxxxxxx> <20090718142339.GA20905@xxxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.22 (Macintosh/20090605)
Christoph Hellwig wrote:
> On Thu, Jul 16, 2009 at 02:43:20PM -0500, Eric Sandeen wrote:
>> Preliminary fiemap testing support based on a test util
>> written by Josef Bacik.
>>
>> For now it's only run with preallocation disabled, because
>> xfs has a tendency to fill in holes with data blocks
>> (EOF prealloc stuff I think) and similar for explicit 
>> preallocation, so this is breaking the preallocation 
>> tests for now, when it finds a "data" block where it expects
>> a preallocated block.
> 
> Wouldn't we be better off to add an fiemap command to xfs_io so that
> we can re-use it instead of having a special test program in xfstests?

I suppose it'd be nice to have, though in this case the test program
also generates all the random patterns and does the checking ... the
fiemap calls are a relatively simple part of it ...

Using xfs_io would be a bit like saying "xfs_io can already generate all
the calls that fsx generates, why not use it instead of a special test
program...." IMHO.

-Eric

<Prev in Thread] Current Thread [Next in Thread>