xfs
[Top] [All Lists]

Re: [PATCH V3] reduce bmv_count in xfs_vn_fiemap

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH V3] reduce bmv_count in xfs_vn_fiemap
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 18 Jul 2009 10:25:39 -0400
Cc: Olaf Weber <olaf@xxxxxxx>, xfs mailing list <xfs@xxxxxxxxxxx>
In-reply-to: <4A5F7B7B.6020903@xxxxxxxxxxx>
References: <4A5E2F01.7030107@xxxxxxxxxxx> <bzybpnkhp62.fsf@xxxxxxxxxxxxxxxxxxxx> <4A5F3DBA.9040005@xxxxxxxxxxx> <4A5F7B7B.6020903@xxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Thu, Jul 16, 2009 at 02:11:55PM -0500, Eric Sandeen wrote:
> V3: bump up by one to accomodate expected bmv header in core

That is probably woth a comment next to setting it in the code.

Otherwise looks good to me, and thanks for the fiemap tests so that
we get test coverage for this.


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>