[Top] [All Lists]

Re: [PATCH] xfstests 219: test fiemap

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfstests 219: test fiemap
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 18 Jul 2009 10:23:39 -0400
Cc: xfs mailing list <xfs@xxxxxxxxxxx>, Josef Bacik <jbacik@xxxxxxxxxx>
In-reply-to: <4A5F82D8.8080709@xxxxxxxxxxx>
References: <4A5F82D8.8080709@xxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Thu, Jul 16, 2009 at 02:43:20PM -0500, Eric Sandeen wrote:
> Preliminary fiemap testing support based on a test util
> written by Josef Bacik.
> For now it's only run with preallocation disabled, because
> xfs has a tendency to fill in holes with data blocks
> (EOF prealloc stuff I think) and similar for explicit 
> preallocation, so this is breaking the preallocation 
> tests for now, when it finds a "data" block where it expects
> a preallocated block.

Wouldn't we be better off to add an fiemap command to xfs_io so that
we can re-use it instead of having a special test program in xfstests?

<Prev in Thread] Current Thread [Next in Thread>