xfs
[Top] [All Lists]

Re: [PATCH] xfstests: don't print scratch mkfs and mount options without

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: don't print scratch mkfs and mount options without scratch device
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Tue, 07 Jul 2009 08:58:29 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20090620173554.GA26470@xxxxxxxxxxxxx>
References: <20090620173554.GA26470@xxxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.22 (Macintosh/20090605)
Christoph Hellwig wrote:
> Also clean up the way the test configuration is printed.
> 
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxxx>

> Index: xfstests-dev/check
> ===================================================================
> --- xfstests-dev.orig/check   2009-06-20 17:31:00.000000000 +0000
> +++ xfstests-dev/check        2009-06-20 17:33:46.000000000 +0000
> @@ -161,18 +161,15 @@
>  
>  [ -f check.time ] || touch check.time
>  
> -FULL_FSTYP_DETAILS=`_full_fstyp_details`
> -FULL_HOST_DETAILS=`_full_platform_details`
> -FULL_MKFS_OPTIONS=`_scratch_mkfs_options`
> -FULL_MOUNT_OPTIONS=`_scratch_mount_options`
> -
> -cat <<EOF
> -FSTYP         -- $FULL_FSTYP_DETAILS
> -PLATFORM      -- $FULL_HOST_DETAILS
> -MKFS_OPTIONS  -- $FULL_MKFS_OPTIONS
> -MOUNT_OPTIONS -- $FULL_MOUNT_OPTIONS
> +# print out our test configuration
> +echo "FSTYP         -- `_full_fstyp_details`"
> +echo "PLATFORM      -- `_full_platform_details`"
> +if [ ! -z "$SCRATCH_DEV" ]; then
> +  echo "MKFS_OPTIONS  -- `_scratch_mkfs_options`"
> +  echo "MOUNT_OPTIONS -- `_scratch_mount_options`"
> +fi
> +echo
>  
> -EOF
>  
>  if [ ! -z "$SCRATCH_DEV" ]; then
>    umount $SCRATCH_DEV 2>/dev/null
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
> 

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH] xfstests: don't print scratch mkfs and mount options without scratch device, Eric Sandeen <=