xfs
[Top] [All Lists]

Re: [PATCH, RFC] default to inode64 on 64-bit systems

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH, RFC] default to inode64 on 64-bit systems
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 6 Jul 2009 14:42:57 -0400
Cc: xfs mailing list <xfs@xxxxxxxxxxx>
In-reply-to: <4A52419E.5020301@xxxxxxxxxxx>
References: <4A52419E.5020301@xxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Mon, Jul 06, 2009 at 01:25:34PM -0500, Eric Sandeen wrote:
> I'm tiring of telling people to use the inode64 mount option
> when they are experiencing bad performance on large xfs 
> filesystems...
> 
> 32-bit userspace is still largely broken when it comes to still
> using 32-bit stat calls, but on 64-bit systems this should be
> safe.
> 
> The only problem here is moving the disk onto a 32-bit system, or using
> 32-bit apps.  But I think it's a small risk.
> 
> What do we think about the following?

Looks good to me, but it could use a comment in the code explaining why
we do this.

<Prev in Thread] Current Thread [Next in Thread>