xfs
[Top] [All Lists]

[PATCH, RFC] default to inode64 on 64-bit systems

To: xfs mailing list <xfs@xxxxxxxxxxx>
Subject: [PATCH, RFC] default to inode64 on 64-bit systems
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Mon, 06 Jul 2009 13:25:34 -0500
User-agent: Thunderbird 2.0.0.21 (X11/20090320)
I'm tiring of telling people to use the inode64 mount option
when they are experiencing bad performance on large xfs 
filesystems...

32-bit userspace is still largely broken when it comes to still
using 32-bit stat calls, but on 64-bit systems this should be
safe.

The only problem here is moving the disk onto a 32-bit system, or using
32-bit apps.  But I think it's a small risk.

What do we think about the following?

Thanks,
-Eric

Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>
---

diff --git a/fs/xfs/linux-2.6/xfs_super.c b/fs/xfs/linux-2.6/xfs_super.c
index a220d36..5d134fd 100644
--- a/fs/xfs/linux-2.6/xfs_super.c
+++ b/fs/xfs/linux-2.6/xfs_super.c
@@ -195,7 +195,9 @@ xfs_parseargs(
         */
        mp->m_flags |= XFS_MOUNT_BARRIER;
        mp->m_flags |= XFS_MOUNT_COMPAT_IOSIZE;
+#if BITS_PER_LONG == 32
        mp->m_flags |= XFS_MOUNT_SMALL_INUMS;
+#endif
 
        /*
         * These can be overridden by the mount option parsing.

<Prev in Thread] Current Thread [Next in Thread>