xfs
[Top] [All Lists]

Re: [PATCH 1/3] xfstests: basic fallocate boundary tests

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH 1/3] xfstests: basic fallocate boundary tests
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 21 Jun 2009 15:16:57 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, ext4 development <linux-ext4@xxxxxxxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <4A3D55C3.6020902@xxxxxxxxxxx>
References: <4A370C2C.6030404@xxxxxxxxxxx> <20090620175824.GA3984@xxxxxxxxxxxxx> <4A3D55C3.6020902@xxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Sat, Jun 20, 2009 at 04:33:55PM -0500, Eric Sandeen wrote:
> hmm this is really testing that xfs_io in particular has fallocate...
> so maybe like this?
> 
> diff --git a/common.rc b/common.rc
> index 39350b3..55aecd6 100644
> --- a/common.rc
> +++ b/common.rc
> @@ -704,6 +704,18 @@ _require_user()
>      [ "$?" == "0" ] || _notrun "$qa_user user not defined."
>  }
>  
> +# check that xfs_io, glibc, kernel, and filesystem all (!) support
> +# fallocate
> +#
> +_require_xfs_io_falloc()
> +     testio=`$XFS_IO_PROG -F -f -c "falloc 0 1m" $TEST_DIR/$tmp.io 2>&1`
> +     rm -f $TEST_DIR/$tmp.io 2>&1 > /dev/null
> +     echo $testio | grep -q "not found" && \
> +             _notrun "xfs_io fallocate support is missing"
> +     echo $testio | grep -q "Operation not supported" && \
> +             _notrun "xfs_io fallocate command failed (old kernel/wrong fs?)"
> +}

Looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>