xfs
[Top] [All Lists]

Re: [PATCH 1/3] xfstests: basic fallocate boundary tests

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH 1/3] xfstests: basic fallocate boundary tests
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 20 Jun 2009 13:58:24 -0400
Cc: xfs-oss <xfs@xxxxxxxxxxx>, ext4 development <linux-ext4@xxxxxxxxxxxxxxx>
In-reply-to: <4A370C2C.6030404@xxxxxxxxxxx>
References: <4A370C2C.6030404@xxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Mon, Jun 15, 2009 at 10:06:20PM -0500, Eric Sandeen wrote:
> This is just like test 072, but using fallocate instead
> of the xfs ioctl.  Just very basic fallocate tests.
> 
> Also adds a "prealloc" group (./check -g prealloc)

Looks good to me, and does the right thing on my 32 bit test VM (notrun)

> +echo $testio | grep -q "not found" && \
> +     _notrun "xfs_io fallocate support is missing"
> +echo $testio | grep -q "Operation not supported" && \
> +     _notrun "xfs_io fallocate command failed (old kernel? wrong fs?)"

Maybe add a _require_fallocate as you need the same check in the next
testcase?

<Prev in Thread] Current Thread [Next in Thread>