xfs
[Top] [All Lists]

Re: [PATCH 1/3] Skip _check_test_fs unless a test is actually run

To: "Theodore Ts'o" <tytso@xxxxxxx>
Subject: Re: [PATCH 1/3] Skip _check_test_fs unless a test is actually run
From: Felix Blyakher <felixb@xxxxxxx>
Date: Fri, 19 Jun 2009 14:05:52 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1245434013-9433-1-git-send-email-tytso@xxxxxxx>
References: <1245434013-9433-1-git-send-email-tytso@xxxxxxx>

On Jun 19, 2009, at 12:53 PM, Theodore Ts'o wrote:

Running _check_test_fs can take a non-trivial amount of time, and if a
test has been skipped because it doesn't work on Linux, or it doesn't
work of for ext4, it's pointless to re-run _check_test_fs.  So move
the call to _check_test_fs so it is only run if a test is actually run.

Definitely makes sense.

Signed-off-by: "Theodore Ts'o" <tytso@xxxxxxx>

Reviewed-by: Felix Blyakher <felixb@xxxxxxx>


---
check |    2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/check b/check
index 545c010..1aae528 100755
--- a/check
+++ b/check
@@ -308,10 +308,10 @@ do
    then
        try="$try $seq"
        n_try=`expr $n_try + 1`
+        _check_test_fs
    fi

    seq="after_$seq"
-    _check_test_fs
done

interrupt=false
--
1.6.3.2.1.gb9f7d.dirty

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs

<Prev in Thread] Current Thread [Next in Thread>