xfs
[Top] [All Lists]

Re: xfs_io: fix test for fallocate on 32bit boxes

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: xfs_io: fix test for fallocate on 32bit boxes
From: Olaf Weber <olaf@xxxxxxx>
Date: Mon, 15 Jun 2009 22:12:13 +0200
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <4A36A448.4060406@xxxxxxxxxxx> (Eric Sandeen's message of "Mon, 15 Jun 2009 14:43:04 -0500")
References: <4A36A448.4060406@xxxxxxxxxxx>
User-agent: Gnus/5.1007 (Gnus v5.10.7) XEmacs/21.4.3 (irix)
Looks good.


Reviewed-by: Olaf Weber <olaf@xxxxxxx>



Eric Sandeen writes:

> xfs_io: fix test for fallocate on 32bit boxes
> As per Red Hat bug 500487, fallocate64 is missing in glibc,
> so attempts to build with fallocate and _FILE_OFFSET_BITS=64
> will fail.

> So, change the config to test the way we will build, and
> it'll fail properly on x86 until glibc gets fixed.

> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>
> ---

> diff --git a/m4/package_libcdev.m4 b/m4/package_libcdev.m4
> index 1ac4666..1c1859d 100644
> --- a/m4/package_libcdev.m4
> +++ b/m4/package_libcdev.m4
> @@ -105,6 +105,9 @@ AC_DEFUN([AC_HAVE_GETMNTINFO],
>  AC_DEFUN([AC_HAVE_FALLOCATE],
>    [ AC_MSG_CHECKING([for fallocate])
>      AC_TRY_LINK([
> +#define _GNU_SOURCE
> +#define _FILE_OFFSET_BITS 64
> +#include <fcntl.h>
>  #include <linux/falloc.h>
>      ], [
>           fallocate(0, 0, 0, 0);


> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs


-- 
Olaf Weber                 SGI               Phone:  +31(0)30-6696752
                           Veldzigt 2b       Fax:    +31(0)30-6696799
Technical Lead             3454 PW de Meern  Vnet:   955-7151
Storage Software           The Netherlands   Email:  olaf@xxxxxxx

<Prev in Thread] Current Thread [Next in Thread>