xfs
[Top] [All Lists]

Re: Kernel 2.6.30: Memory/XFS leak, OOM killer kills many processes

To: Felix Blyakher <felixb@xxxxxxx>
Subject: Re: Kernel 2.6.30: Memory/XFS leak, OOM killer kills many processes
From: Justin Piszcz <jpiszcz@xxxxxxxxxxxxxxx>
Date: Fri, 12 Jun 2009 04:37:32 -0400 (EDT)
Cc: Eric Sandeen <sandeen@xxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <96F5FBF8-17B6-4AA9-BAB4-377AF596692C@xxxxxxx>
References: <alpine.DEB.2.00.0906111158470.2563@xxxxxxxxxxxxxxxx> <alpine.DEB.2.00.0906111255280.6809@xxxxxxxxxxxxxxxx> <4A313F84.20900@xxxxxxxxxxx> <96F5FBF8-17B6-4AA9-BAB4-377AF596692C@xxxxxxx>
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)


On Thu, 11 Jun 2009, Felix Blyakher wrote:


On Jun 11, 2009, at 12:31 PM, Eric Sandeen wrote:

Justin Piszcz wrote:

On Thu, 11 Jun 2009, Justin Piszcz wrote:

The following should fix it:

diff --git a/fs/xfs/xfs_bmap.c b/fs/xfs/xfs_bmap.c
index 4b0f6ef..7928b99 100644
--- a/fs/xfs/xfs_bmap.c
+++ b/fs/xfs/xfs_bmap.c
@@ -6086,6 +6086,7 @@ xfs_getbmap(
                     break;
     }

+       kmem_free(out);
     return error;
}


Felix

Just FYI if anyone tries to run the patch it will not work:

# patch -p1 < ../xfs.patch patching file fs/xfs/xfs_bmap.c
patch: **** malformed patch at line 11: }

So just goto line ~6086 and add the kmem_free(out); above the return error.

Status:
This patch fixes the problem, thanks!

Justin.

<Prev in Thread] Current Thread [Next in Thread>