xfs
[Top] [All Lists]

Re: [PATCH] xfstests: Skip dump _cleanup if filesystem is not xfs

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: Skip dump _cleanup if filesystem is not xfs
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 10 Jun 2009 14:54:45 -0400
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <4A2FF2CB.1060805@xxxxxxxxxxx>
References: <4A2FF2CB.1060805@xxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Wed, Jun 10, 2009 at 12:52:11PM -0500, Eric Sandeen wrote:
> Skip dump _cleanup if filesystem is not xfs
> 
> Many/most dump tests include common.dump before checking
> supported fs, and this means that even if the dump tests
> are skipped, the sleep & filesystem check in _cleanup
> gets run, which makes it take rather a long time to
> skip these tests for non-xfs filesystems.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---
> 
> 
> diff --git a/common.dump b/common.dump
> index 94de07f..d5aadfc 100644
> --- a/common.dump
> +++ b/common.dump
> @@ -233,6 +233,12 @@ _wipe_fs()
>  #
>  _cleanup()
>  {
> +    # Some tests include this before checking _supported_fs xfs
> +    # and the sleeps & checks get annoying
> +    if [ "$FSTYP" != "xfs" ]; then
> +       return
> +    fi

Looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>