xfs
[Top] [All Lists]

Re: [PATCH] xfstests: allow more xfs_io tests to be generic

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: allow more xfs_io tests to be generic
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Mon, 08 Jun 2009 19:49:22 -0500
Cc: Eric Sandeen <sandeen@xxxxxxxxxx>, xfs mailing list <xfs@xxxxxxxxxxx>
In-reply-to: <20090608232559.GA28568@xxxxxxxxxxxxx>
References: <4A2D4F51.5050906@xxxxxxxxxx> <20090608232559.GA28568@xxxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.21 (Macintosh/20090302)
Christoph Hellwig wrote:
> On Mon, Jun 08, 2009 at 12:50:09PM -0500, Eric Sandeen wrote:
>> What do folks think of this?  These tests just do generic
>> reads & writes with xfs_io; if we add a "-F" they will run
>> on other filesystems.
> 
> Looks good to me.  Btw, I really wonder if we want to keep the -F
> flag to xfs_io.  Seems rather pointless to restrict
> perfectly normal I/O to a single filesystem type.  And even for XFS
> specific ioctls we'd get a good enough error code back to handle it.

I was thinking the same thing.

-Eric

<Prev in Thread] Current Thread [Next in Thread>