xfs
[Top] [All Lists]

Re: [PATCH] xfstests: allow more xfs_io tests to be generic

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfstests: allow more xfs_io tests to be generic
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 8 Jun 2009 19:25:59 -0400
Cc: xfs mailing list <xfs@xxxxxxxxxxx>
In-reply-to: <4A2D4F51.5050906@xxxxxxxxxx>
References: <4A2D4F51.5050906@xxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Mon, Jun 08, 2009 at 12:50:09PM -0500, Eric Sandeen wrote:
> What do folks think of this?  These tests just do generic
> reads & writes with xfs_io; if we add a "-F" they will run
> on other filesystems.

Looks good to me.  Btw, I really wonder if we want to keep the -F
flag to xfs_io.  Seems rather pointless to restrict
perfectly normal I/O to a single filesystem type.  And even for XFS
specific ioctls we'd get a good enough error code back to handle it.

<Prev in Thread] Current Thread [Next in Thread>