xfs
[Top] [All Lists]

Re: [PATCH] xfstests: Allow fsx tests to run on generic filesystems

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: Allow fsx tests to run on generic filesystems
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 8 Jun 2009 12:16:46 -0400
Cc: xfs mailing list <xfs@xxxxxxxxxxx>
In-reply-to: <4A2D31E3.3090108@xxxxxxxxxxx>
References: <4A2D31E3.3090108@xxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Mon, Jun 08, 2009 at 10:44:35AM -0500, Eric Sandeen wrote:
> There is already logic in 075 to gracefully skip nfs for fsx
> invocations with -x (xfs-specific preallocation) - just extend
> this to any non-xfs filesystem, and add to test 112 as well.
> 
> Later we can change this behavior to use fallocate and include
> more filesystems but this gets some fsx coverage for now.
> 
> Test 127 doesn't seem to have anything xfs-specific, so mark
> that as generic too.

Good bandaid for now, but it would be even better to get a fsx
version using the generic prealloc calls one day :)


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>