xfs
[Top] [All Lists]

Re: [PATCH 6/7] xfs: use generic inode iterator in xfs_qm_dqrele_all_ino

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 6/7] xfs: use generic inode iterator in xfs_qm_dqrele_all_inodes
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Fri, 05 Jun 2009 14:15:38 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20090514171559.029154000@xxxxxxxxxxxxxxxxxxxxxx>
References: <20090514171233.942489000@xxxxxxxxxxxxxxxxxxxxxx> <20090514171559.029154000@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.21 (X11/20090320)
Christoph Hellwig wrote:

> Use xfs_inode_ag_iterator instead of opencoding the inode walk in the
> quota code.  Mark xfs_inode_ag_iterator and xfs_sync_inode_valid non-static
> to allow using them from the quota code.
> 
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> 
> Index: xfs/fs/xfs/quota/xfs_qm_syscalls.c
> ===================================================================
> --- xfs.orig/fs/xfs/quota/xfs_qm_syscalls.c   2009-05-13 14:52:54.087659167 
> +0200
> +++ xfs/fs/xfs/quota/xfs_qm_syscalls.c        2009-05-13 14:57:36.531661369 
> +0200

...

> +     error = xfs_sync_inode_valid(ip, pag);
> +     if (error)
> +             return 0;

Does this need the same error propagation treatment as 5/7 ?

-Eric

<Prev in Thread] Current Thread [Next in Thread>