xfs
[Top] [All Lists]

Re: [PATCH] xfstests: Check for xlog_assign_lsn in xfs headers

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfstests: Check for xlog_assign_lsn in xfs headers
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 3 Jun 2009 15:43:50 -0400
Cc: xfs mailing list <xfs@xxxxxxxxxxx>
In-reply-to: <4A26C53F.5080105@xxxxxxxxxx>
References: <4A26C53F.5080105@xxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Wed, Jun 03, 2009 at 01:47:27PM -0500, Eric Sandeen wrote:
> Check for xlog_assign_lsn in xfs headers
> 
> Checking for libxfs.h isn't enough; some debian installs
> have libxfs.h but no xlog_assign_lsn, and the loggen build still
> fails.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> Tested-by: Aneesh Kumar K.V <aneesh.kumar@xxxxxxxxxxxxxxxxxx>

I don't actually have a box with an old enough libxfs.h, but the
test looks sane to me.

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>