| To: | Eric Sandeen <sandeen@xxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH V3] xfstests: add aio-dio-regress tests |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Wed, 3 Jun 2009 15:38:46 -0400 |
| Cc: | xfs mailing list <xfs@xxxxxxxxxxx> |
| In-reply-to: | <4A255E80.9000209@xxxxxxxxxxx> |
| References: | <4A255E80.9000209@xxxxxxxxxxx> |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
On Tue, Jun 02, 2009 at 12:16:48PM -0500, Eric Sandeen wrote:
> +AIO_TEST=aio-dio-extend-stat
> +
> +rm -f $TEST_DIR/aio-testfile
> +echo "==${AIO_TEST}=="
> +src/aio-dio-regress/$AIO_TEST $TEST_DIR/aio-testfile 2>&1
the AIO_TEST variable seems superflous in all these tests. Also
the echo isn't really strictly needed if only running one thing
anyway.
Modulo these nitpicks looks good to me,
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] xfstests: don't run 122 if required headers aren't found, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH] xfstests: Check for xlog_assign_lsn in xfs headers, Christoph Hellwig |
| Previous by Thread: | [PATCH V3] xfstests: add aio-dio-regress tests, Eric Sandeen |
| Next by Thread: | [PATCH] Fix mode for include/install-sh so that attempts, robert herndon |
| Indexes: | [Date] [Thread] [Top] [All Lists] |