[Top] [All Lists]

Re: [PATCH] xfstests: Make the SCRATCH_DEV optional

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfstests: Make the SCRATCH_DEV optional
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 3 Jun 2009 13:19:04 -0400
Cc: xfs mailing list <xfs@xxxxxxxxxxx>
In-reply-to: <4A26AC60.6060401@xxxxxxxxxx>
References: <4A26AC60.6060401@xxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Wed, Jun 03, 2009 at 12:01:20PM -0500, Eric Sandeen wrote:
> Tests will fail gracefully if there is no SCRATCH_DEV defined, so change
> the check script to allow it, and update README to reflect this.
> This just makes it simpler to set up the tests, at the expense of
> coverage.
> Long term it might be nice to allow either SCRATCH_DEV xor TEST_DEV
> to be missing, but for now this is simple.

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>