xfs
[Top] [All Lists]

Re: [PATCH] xfstests: reiserfs, gfs2, btrfs support

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: reiserfs, gfs2, btrfs support
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 29 May 2009 15:45:00 -0400
Cc: xfs mailing list <xfs@xxxxxxxxxxx>
In-reply-to: <4A20373A.9070403@xxxxxxxxxxx>
References: <4A20373A.9070403@xxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Fri, May 29, 2009 at 02:27:54PM -0500, Eric Sandeen wrote:
> This patch gets reiserfs, gfs2, and btrfs off the ground.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>
> ---
> 
> diff --git a/common.rc b/common.rc
> index 54c36f3..c3e77e9 100644
> --- a/common.rc
> +++ b/common.rc
> @@ -53,6 +53,14 @@ _mount_opts()
>       # acls & xattrs aren't turned on by default on ext$FOO
>       export MOUNT_OPTIONS="-o acl,user_xattr $EXT_MOUNT_OPTIONS"
>       ;;
> +    reiserfs)
> +     # acls & xattrs aren't turned on by default on reiserfs
> +     export MOUNT_OPTIONS="-o acl,user_xattr $REISERFS_MOUNT_OPTIONS"
> +     ;;
> +    gfs2)
> +     # acls aren't turned on by default on gfs2
> +     export MOUNT_OPTIONS="-o acl $GFS2_MOUNT_OPTIONS"
> +     ;;

I wonder if we should find some way to auto-probe these options somehow.
It looks like lots of filesystems copied that utter braindamage from ext2 :(


Anyway the patch looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>