xfs
[Top] [All Lists]

Re: [PATCH V2] xfstests 206: test for overflow in growfs size calculatio

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH V2] xfstests 206: test for overflow in growfs size calculation
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 29 May 2009 10:50:25 -0400
Cc: xfs mailing list <xfs@xxxxxxxxxxx>, Richard.Ems@xxxxxxxxxxxxxxxxx
In-reply-to: <4A1EFE55.4020505@xxxxxxxxxxx>
References: <4A1EF50D.8090900@xxxxxxxxxx> <4A1EFE55.4020505@xxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Thu, May 28, 2009 at 04:12:53PM -0500, Eric Sandeen wrote:
> Test trim of last small AG for large filesystem resizes
> 
> As reported at
> http://article.gmane.org/gmane.comp.file-systems.xfs.general/29187
> this trimming may cause an overflow in the new size calculation.
> 
> Patch to fix it, and testcase at
> http://article.gmane.org/gmane.comp.file-systems.xfs.general/29193
> 
> V2: now with proper expected (resized) output!

This fails for me in really weird ways (Debian -testing, i386):


--- 206.out     2009-05-29 14:44:54.000000000 +0000
+++ 206.out.bad 2009-05-29 14:46:01.000000000 +0000
@@ -1,30 +1,18 @@
 QA output created by 206
 === xfs_io ===
+ftruncate: File too large
 === mkfs.xfs ===
+existing superblock read failed: Success
+mkfs.xfs: pwrite64 failed: Invalid argument
 meta-data=FILE                   isize=256    agcount=52, agsize=76288719 blks
          =                       sectsz=512   attr=2
 data     =                       bsize=4096   blocks=3905982455, imaxpct=5
          =                       sunit=0      swidth=0 blks
 naming   =version 2              bsize=4096   ascii-ci=0
-log      =internal log           bsize=4096   blocks=32768, version=2
-         =                       sectsz=512   sunit=0 blks, lazy-count=0
-realtime =none                   extsz=4096   blocks=0, rtextents=0
-=== xfs_growfs ===
-meta-data=FILE                   isize=256    agcount=52, agsize=76288719 blks
-         =                       sectsz=512   attr=2
-data     =                       bsize=4096   blocks=3905982455, imaxpct=5
-         =                       sunit=0      swidth=0 blks
-naming   =version 2              bsize=4096   ascii-ci=0
-log      =internal               bsize=4096   blocks=32768, version=2
-         =                       sectsz=512   sunit=0 blks, lazy-count=0
-realtime =none                   extsz=4096   blocks=0, rtextents=0
-data blocks changed from 3905982455 to 4882478016
-=== xfs_info ===
-meta-data=FILE                   isize=256    agcount=64, agsize=76288719 blks
-         =                       sectsz=512   attr=2
-data     =                       bsize=4096   blocks=4882478016, imaxpct=5
-         =                       sunit=0      swidth=0 blks
-naming   =version 2              bsize=4096   ascii-ci=0
-log      =internal               bsize=4096   blocks=32768, version=2
+log      =internal log           bsize=4096   blocks=521728, version=2
          =                       sectsz=512   sunit=0 blks, lazy-count=0
 realtime =none                   extsz=4096   blocks=0, rtextents=0
+mount: /dev/loop0: can't read superblock
+!!! failed to loopback mount
+(see 206.full for details)
+umount: /mnt/test/tmpdir.4994: not mounted

<Prev in Thread] Current Thread [Next in Thread>