Re: [PATCH 1/9 V2] Use xfs.h rather than libxfs.h

To:	Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject:	Re: [PATCH 1/9 V2] Use xfs.h rather than libxfs.h
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Thu, 28 May 2009 12:22:24 -0400
Cc:	Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to:	<4A1EB8DE.40108@xxxxxxxxxxx>
References:	<1243450413-12681-1-git-send-email-sandeen@xxxxxxxxxxx> <1243450413-12681-2-git-send-email-sandeen@xxxxxxxxxxx> <20090528095657.GA651@xxxxxxxxxxxxx> <4A1EB8DE.40108@xxxxxxxxxxx>
User-agent:	Mutt/1.5.18 (2008-05-17)

> +#ifndef XFS_SUPER_MAGIC
> +#define XFS_SUPER_MAGIC 0x58465342
> +#endif

This should eventually be replaced by just using platform_test_xfs_fd
from xfs.h


But for now the patch is fine,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/9] xfstests: more generic fs work, Eric Sandeen [PATCH 4/9] 069: make scratch mkfs quiet, Eric Sandeen Re: [PATCH 4/9] 069: make scratch mkfs quiet, Christoph Hellwig [PATCH 1/9] Use xfs.h rather than libxfs.h, Eric Sandeen Re: [PATCH 1/9] Use xfs.h rather than libxfs.h, Christoph Hellwig [PATCH 0.5/9] Replace MAXNAMELEN with NAME_MAX + 1, Eric Sandeen Re: [PATCH 0.5/9] Replace MAXNAMELEN with NAME_MAX + 1, Christoph Hellwig [PATCH 1/9 V2] Use xfs.h rather than libxfs.h, Eric Sandeen Re: [PATCH 1/9 V2] Use xfs.h rather than libxfs.h, Christoph Hellwig <= [PATCH 2/9] Make libxfs.h optional, Eric Sandeen Re: [PATCH 2/9] Make libxfs.h optional, Christoph Hellwig Re: [PATCH 2/9] Make libxfs.h optional, Eric Sandeen Re: [PATCH 2/9] Make libxfs.h optional, Christoph Hellwig Re: [PATCH 2/9] Make libxfs.h optional, Eric Sandeen [PATCH 3/9] Support "generic" filesystem type, Eric Sandeen Re: [PATCH 3/9] Support "generic" filesystem type, Christoph Hellwig [PATCH 7/9] Set default extN mount options, Eric Sandeen Re: [PATCH 7/9] Set default extN mount options, Michael Monnerie Re: [PATCH 7/9] Set default extN mount options, Christoph Hellwig

Previous by Date:	[PATCH 1/9 V2] Use xfs.h rather than libxfs.h, Eric Sandeen
Next by Date:	[PATCH] remove remaining useless if-before-frees, Eric Sandeen
Previous by Thread:	[PATCH 1/9 V2] Use xfs.h rather than libxfs.h, Eric Sandeen
Next by Thread:	[PATCH 2/9] Make libxfs.h optional, Eric Sandeen
Indexes:	[Date] [Thread] [Top] [All Lists]