xfs
[Top] [All Lists]

Re: [PATCH 2/9] Make libxfs.h optional

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/9] Make libxfs.h optional
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Thu, 28 May 2009 11:15:04 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20090528153517.GA15293@xxxxxxxxxxxxx>
References: <1243450413-12681-1-git-send-email-sandeen@xxxxxxxxxxx> <1243450413-12681-3-git-send-email-sandeen@xxxxxxxxxxx> <20090528095749.GB651@xxxxxxxxxxxxx> <4A1EA6E5.50805@xxxxxxxxxxx> <20090528153517.GA15293@xxxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.21 (X11/20090320)
Christoph Hellwig wrote:
> On Thu, May 28, 2009 at 09:59:49AM -0500, Eric Sandeen wrote:
>> Christoph Hellwig wrote:
>>> On Wed, May 27, 2009 at 01:53:26PM -0500, Eric Sandeen wrote:
>>>> libxfs.h is really only needed for the loggen test;
>>>> make it config-time optional.
>>> Maybe we should just move loggen into xfsprogs?
>> Perhaps, though it has no use outside of qa ... even if we do that it'll
>> take a while to trickle into people's xfsprogs, so any problem with
>> putting this patch in for now, even if we move loggen?
> 
> I will send a patch to add loggen to xfsprogs ASAP.  After that we can
> remove loggen and thus the requirement for libxfs.h from xfstests
> completely.  The tests that use loggen would ismply check for a
> xfs_loggen binary  in their PATH and not run, so far less drama then
> the current situation.

Ok, sounds fine.

-Eric

<Prev in Thread] Current Thread [Next in Thread>