xfs
[Top] [All Lists]

Re: [PATCH 7/9] Set default extN mount options

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 7/9] Set default extN mount options
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Thu, 28 May 2009 09:57:45 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20090528100122.GG651@xxxxxxxxxxxxx>
References: <1243450413-12681-1-git-send-email-sandeen@xxxxxxxxxxx> <1243450413-12681-8-git-send-email-sandeen@xxxxxxxxxxx> <20090528100122.GG651@xxxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.21 (X11/20090320)
Christoph Hellwig wrote:

>> @@ -585,7 +589,7 @@ _require_scratch()
>>                   _notrun "this test requires a valid \$SCRATCH_DEV"
>>               fi
>>               ;;
>> -    nfs*|ext2|ext3|reiserfs)
>> +    nfs*|ext2|ext3|ext4|reiserfs)
>>               echo $SCRATCH_DEV | grep -q ":" > /dev/null 2>&1
>>               if [ ! -z "$SCRATCH_DEV" -a ! -b "$SCRATCH_DEV" -a "$?" != "0" 
>> ]
> 
> This whole function looks fishy to me, but just treating ext4 the same
> as ext2/ext3 makes sense at least.

I agree, I Need to sort out what's going on here but this was a "make it
work" patch :)

Thanks,

-Eric

> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> 

<Prev in Thread] Current Thread [Next in Thread>