[Top] [All Lists]

Re: [PATCH 8/9] Enable generic filesystems to be fsck'd

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH 8/9] Enable generic filesystems to be fsck'd
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 28 May 2009 08:51:28 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1243450413-12681-9-git-send-email-sandeen@xxxxxxxxxxx>
References: <1243450413-12681-1-git-send-email-sandeen@xxxxxxxxxxx> <1243450413-12681-9-git-send-email-sandeen@xxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Wed, May 27, 2009 at 01:53:32PM -0500, Eric Sandeen wrote:
> This includes a fair bit of rearranging to avoid code duplication,
> but the goal is to allow 'fsck -n -t $FSTYP $device' to be run on
> any generic filesystem.
> Any FS for which this doesn't work will need it's own fsck routine.

Looks generally good, some comments:

 - I would get rid of _check_generic_test_fs and just opencode the
   _check_generic_filesystem $TEST_DEV in the two callers.
 - why the odd calling convention of _is_mounted which allows to
   optionally pass the fstype?  Currently we only have one caller
   that doesn't pass it, and if we grow one that needs it I would
   rather always pass it explicitly..

Btw, I seems like _check_testdir is never actually called, and I can't
really see a reason why it would be different from _check_test_fs.

<Prev in Thread] Current Thread [Next in Thread>