xfs
[Top] [All Lists]

Re: [PATCH 1/9] Use xfs.h rather than libxfs.h

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH 1/9] Use xfs.h rather than libxfs.h
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 28 May 2009 05:56:57 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1243450413-12681-2-git-send-email-sandeen@xxxxxxxxxxx>
References: <1243450413-12681-1-git-send-email-sandeen@xxxxxxxxxxx> <1243450413-12681-2-git-send-email-sandeen@xxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Wed, May 27, 2009 at 01:53:25PM -0500, Eric Sandeen wrote:
> Use xfs/xfs.h when possible rather than xfs/libxfs.h,
> now that libxfs.h isn't part of a normal xfsprogs-devel
> install.

> +/*
> + * MAXNAMELEN is the length (including the terminating null) of
> + * the longest permissible file (component) name.
> + */
> +#ifndef MAXNAMELEN
> +#define MAXNAMELEN 256
> +#endif

Just switch all users to the posix NAME_MAX instead.  Note that NAME_MAX
does not include the NULL termination, so it's one-off vs MAXNAMELEN.

> diff --git a/src/godown.c b/src/godown.c
> index 4105aee..fa04f24 100644
> --- a/src/godown.c
> +++ b/src/godown.c
> @@ -18,7 +18,7 @@
>  
>  #include "global.h"
>  
> -/* These should be in libxfs.h */
> +/* These should be in xfs.h */
>  #ifndef XFS_IOC_GOINGDOWN
>  #define XFS_IOC_GOINGDOWN           _IOR ('X', 125, __uint32_t)
>  #endif

Might be worth to remove now as we had it in xfs_fs.h forever.

<Prev in Thread] Current Thread [Next in Thread>