xfs
[Top] [All Lists]

Re: [PATCH 2/7] xfs: split inode flushing from xfs_sync_inodes_ag

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/7] xfs: split inode flushing from xfs_sync_inodes_ag
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Wed, 27 May 2009 15:11:44 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20090527105841.GA10545@xxxxxxxxxxxxx>
References: <20090514171233.942489000@xxxxxxxxxxxxxxxxxxxxxx> <20090514171558.298098000@xxxxxxxxxxxxxxxxxxxxxx> <4A1C54FB.2080705@xxxxxxxxxxx> <20090527105841.GA10545@xxxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.21 (X11/20090320)
Christoph Hellwig wrote:
> On Tue, May 26, 2009 at 03:45:47PM -0500, Eric Sandeen wrote:
>> What happened to the XFS_IFLUSH_DELWRI case?
>>
>> You mentioned "keep the current behavior exactly" but this seems like a
>> change, no?
> 
> Yeah, this got lost when playing with variations of the patch.  Correct
> version below:
> 
> Subject: xfs: split inode flushing from xfs_sync_inodes_ag
> From: Christoph Hellwig <hch@xxxxxx>
> 
> 
> In many cases we only want to sync inode metadata. Split out the inode
> flushing into a separate helper to prepare factoring the inode sync code.
> 
> Based on a patch from Dave Chinner, but redone to keep the current behaviour
> exactly and leave changes to the flushing logic to another patch.
> 
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> 

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>