| To: | Eric Sandeen <sandeen@xxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH V2] drop xfs_version.h |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Tue, 26 May 2009 16:03:03 -0400 |
| Cc: | Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs mailing list <xfs@xxxxxxxxxxx> |
| In-reply-to: | <4A1C4A44.1030309@xxxxxxxxxxx> |
| References: | <4A1C449E.7070004@xxxxxxxxxxx> <20090526195140.GA4368@xxxxxxxxxxxxx> <4A1C4A44.1030309@xxxxxxxxxxx> |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
On Tue, May 26, 2009 at 03:00:04PM -0500, Eric Sandeen wrote: > xfs_version.h is about 30 lines for the benefit of > one single define, which seems a bit silly. > > Just drop the file and hardcode "SGI XFS" the 2 > places it's used. > > v2: merge together 2 now-shorter lines. > > Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx> Reviewed-by: Christoph Hellwig <hch@xxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH V2] drop xfs_version.h, Eric Sandeen |
|---|---|
| Next by Date: | Re: [PATCH 1/7] xfs: split inode data writeback from xfs_sync_inodes_ag, Eric Sandeen |
| Previous by Thread: | [PATCH V2] drop xfs_version.h, Eric Sandeen |
| Next by Thread: | [XFS updates] XFS development tree branch, master, updated. v2.6.29-6707-g0963248, xfs |
| Indexes: | [Date] [Thread] [Top] [All Lists] |