xfs
[Top] [All Lists]

Re: [PATCH] xfsprogs: fix readline/editline for xfs_io and xfs_quota

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfsprogs: fix readline/editline for xfs_io and xfs_quota
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Sat, 16 May 2009 17:14:37 -0500
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <4A0F37CF.4030709@xxxxxxxxxxx>
References: <4A0E177C.7070902@xxxxxxxxxxx> <20090516203413.GB28186@xxxxxxxxxxxxx> <4A0F37CF.4030709@xxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.21 (Macintosh/20090302)
Eric Sandeen wrote:
> Christoph Hellwig wrote:

...

>> (btw, any reason we don't enable readline support by default if
>> we find the headers installed?)
>>
> 
> I dunno... Nathan, any idea?  Maybe some git-digging is in order.
> 
> -Eric
> 

xfsprogs-2.4.2 (25 March 2003)
        - Added the xfs_io(8) command, an xfs_db(8) alike command
          for testing and debugging the XFS file IO path.
        - Added an optional dependency on the GNU readline library
          which is "off" by default and enabled with the configure
          option --enable-readline=yes; it affects the interactive
          tools only (xfs_db and now xfs_io).

looks like it was done that way originally and never changed, commit
e246ba5f93896ac873d25f65c05496e6e2c69e34 I think.

Fine by me to make the default yes if it's there ...

-Eric

<Prev in Thread] Current Thread [Next in Thread>