xfs
[Top] [All Lists]

Re: [PATCH] xfsprogs: fix readline/editline for xfs_io and xfs_quota

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfsprogs: fix readline/editline for xfs_io and xfs_quota
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Sat, 16 May 2009 17:01:51 -0500
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <20090516203413.GB28186@xxxxxxxxxxxxx>
References: <4A0E177C.7070902@xxxxxxxxxxx> <20090516203413.GB28186@xxxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.21 (Macintosh/20090302)
Christoph Hellwig wrote:
> On Fri, May 15, 2009 at 08:31:40PM -0500, Eric Sandeen wrote:
>> It looks like libxcmd wasn't ever being built with -DENABLE_READLINE
>> even when it was asked for by configure --enable-readline=yes
>> so xfs_io & xfs_quota didn't get the functionality.
>>
>> This seems to fix it up for me (fixes editline too while we're
>> at it).
> 
> I've also been wondering for quite some while why xfs_io didn't have
> working readline support.
> 
> This patch makes it work for me and looks good:
> 
> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> 
> (btw, any reason we don't enable readline support by default if
> we find the headers installed?)
> 

I dunno... Nathan, any idea?  Maybe some git-digging is in order.

-Eric

<Prev in Thread] Current Thread [Next in Thread>