xfs
[Top] [All Lists]

Re: [PATCH] xfsprogs: add fallocate command to xfs_io

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfsprogs: add fallocate command to xfs_io
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 16 May 2009 16:40:25 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <4A0DE88C.2040401@xxxxxxxxxxx>
References: <4A077195.3070708@xxxxxxxxxxx> <20090515171324.GA14804@xxxxxxxxxxxxx> <20090515172711.GA23630@xxxxxxxxxxxxx> <4A0DB97F.4020201@xxxxxxxxxxx> <4A0DE88C.2040401@xxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Fri, May 15, 2009 at 05:11:24PM -0500, Eric Sandeen wrote:
> Instead of above does this work better?
> 
> (just change AC_TRY_COMPILE to AC_TRY_LINK)

Yes, that correctly detects fallocate as not present for me and
thus gives a working fallocate.

> 
> AC_DEFUN([AC_HAVE_FALLOCATE],
>   [ AC_MSG_CHECKING([for fallocate])
>     AC_TRY_LINK([
> #include <linux/falloc.h>
>     ], [
>          fallocate(0, 0, 0, 0);

Why do you nee to include <linux/falloc.h> here anyway?  You don't use
any of the constants, and the fallocate libc call must be in another
headers, so it obviously compiles even without a defintion for it.

<Prev in Thread] Current Thread [Next in Thread>