xfs
[Top] [All Lists]

Re: [PATCH] xfsprogs: fix readline/editline for xfs_io and xfs_quota

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfsprogs: fix readline/editline for xfs_io and xfs_quota
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 16 May 2009 16:34:13 -0400
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <4A0E177C.7070902@xxxxxxxxxxx>
References: <4A0E177C.7070902@xxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Fri, May 15, 2009 at 08:31:40PM -0500, Eric Sandeen wrote:
> It looks like libxcmd wasn't ever being built with -DENABLE_READLINE
> even when it was asked for by configure --enable-readline=yes
> so xfs_io & xfs_quota didn't get the functionality.
> 
> This seems to fix it up for me (fixes editline too while we're
> at it).

I've also been wondering for quite some while why xfs_io didn't have
working readline support.

This patch makes it work for me and looks good:


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

(btw, any reason we don't enable readline support by default if
we find the headers installed?)

<Prev in Thread] Current Thread [Next in Thread>