xfs
[Top] [All Lists]

Re: [PATCH] xfsprogs: add fallocate command to xfs_io

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfsprogs: add fallocate command to xfs_io
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Fri, 15 May 2009 13:50:39 -0500
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <20090515172711.GA23630@xxxxxxxxxxxxx>
References: <4A077195.3070708@xxxxxxxxxxx> <20090515171324.GA14804@xxxxxxxxxxxxx> <20090515172711.GA23630@xxxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.21 (Macintosh/20090302)
Christoph Hellwig wrote:
> On Fri, May 15, 2009 at 01:13:24PM -0400, Christoph Hellwig wrote:
>> On Sun, May 10, 2009 at 07:30:13PM -0500, Eric Sandeen wrote:
>>> Based on Dave's earlier patch, but now we have an fallocate
>>> glibc call... this also adds autoconf magic and a manpage 
>>> update.
>>>
>>> (hopefully not too #ifdef-heavy....)
>> Looks good to me and seems to work.
> 
> Actually that was spoken too fast.  On my Debian -testing system it
> detects fallocate as available because <linux/falloc.h> exists, but the
> glibc doesn't actually support a falloc(3) yet.  So either the detection
> needs to be improved or we need to use the raw syscall.

Ok, I think I know how to make the detection work better, I'll fix that up.

-Eric

<Prev in Thread] Current Thread [Next in Thread>