xfs
[Top] [All Lists]

Re: [PATCH] xfsprogs: add fallocate command to xfs_io

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfsprogs: add fallocate command to xfs_io
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 15 May 2009 13:27:11 -0400
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <20090515171324.GA14804@xxxxxxxxxxxxx>
References: <4A077195.3070708@xxxxxxxxxxx> <20090515171324.GA14804@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Fri, May 15, 2009 at 01:13:24PM -0400, Christoph Hellwig wrote:
> On Sun, May 10, 2009 at 07:30:13PM -0500, Eric Sandeen wrote:
> > Based on Dave's earlier patch, but now we have an fallocate
> > glibc call... this also adds autoconf magic and a manpage 
> > update.
> > 
> > (hopefully not too #ifdef-heavy....)
> 
> Looks good to me and seems to work.

Actually that was spoken too fast.  On my Debian -testing system it
detects fallocate as available because <linux/falloc.h> exists, but the
glibc doesn't actually support a falloc(3) yet.  So either the detection
needs to be improved or we need to use the raw syscall.

<Prev in Thread] Current Thread [Next in Thread>