xfs
[Top] [All Lists]

Re: [PATCH] xfsprogs: add fallocate command to xfs_io

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfsprogs: add fallocate command to xfs_io
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 15 May 2009 13:13:24 -0400
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <4A077195.3070708@xxxxxxxxxxx>
References: <4A077195.3070708@xxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Sun, May 10, 2009 at 07:30:13PM -0500, Eric Sandeen wrote:
> Based on Dave's earlier patch, but now we have an fallocate
> glibc call... this also adds autoconf magic and a manpage 
> update.
> 
> (hopefully not too #ifdef-heavy....)

Looks good to me and seems to work.

> +#if defined(HAVE_FALLOCATE)
> +#include <linux/falloc.h>
> +#endif

What about just using #ifdef HAVE_FALLOCATE everywhere?


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>