xfs
[Top] [All Lists]

Re: [PATCH 2/7] xfs: split inode flushing from xfs_sync_inodes_ag

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/7] xfs: split inode flushing from xfs_sync_inodes_ag
From: Sujit Karataparambil <sjt.kar@xxxxxxxxx>
Date: Fri, 15 May 2009 10:22:31 +0530
Cc: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=q44lsTCLcL3Y0VLx1Vv6bnd01ARydILnS8jBuD2EqQQ=; b=g97UyeZZ2RKAj45CHHpsIEfbf21LqNstJDWrtlVFHuPnHLZ2K3oejwNuDN1sfeYx8A OVgDul1srX5gekiCQ9ELGbQ6q0YxTK9jZaxhaxgDk9cJxQ11OWtGXfEjlzqAHkad863I fBTYneeH1mVomCZRHLy6IkAgudlOVEUqRITAM=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=YQGFsZqfq9+7jHr66xaW873H9I35rDaBuluhYSYEXA9fIsaqJTg9hX9sx5DPIAoZuE j7cbmD43yVRQqlaplRtZRPKDdEStgdDkt3IJf1VVmV+jkZoeoL8EGF26F7/18vjJWEMj RZeIiop3dlO+nvy8SwjhRjoYr8PPO0bE8vvrA=
In-reply-to: <20090514171558.298098000@xxxxxxxxxxxxxxxxxxxxxx>
References: <20090514171233.942489000@xxxxxxxxxxxxxxxxxxxxxx> <20090514171558.298098000@xxxxxxxxxxxxxxxxxxxxxx>
> +STATIC int
> +xfs_sync_inode_attr(
> +       struct xfs_inode        *ip,
> +       int                     flags)
> +{
> +       int                     error = 0;
> +
> +       xfs_ilock(ip, XFS_ILOCK_SHARED);
> +       if (xfs_inode_clean(ip))
> +               goto out_unlock;
> +       if (!xfs_iflock_nowait(ip)) {
> +               if (!(flags & SYNC_WAIT))
> +                       goto out_unlock;
> +               xfs_iflock(ip);
> +       }
> +
> +       if (xfs_inode_clean(ip)) {
> +               xfs_ifunlock(ip);
> +               goto out_unlock;
> +       }
> +
> +       error = xfs_iflush(ip, XFS_IFLUSH_SYNC);
> +
> + out_unlock:
> +       xfs_iunlock(ip, XFS_ILOCK_SHARED);
> +       return error;

here also should there be an
xfs_sync_inode_data(ip, flags);
xfs_iflush(ip, XFS_IFLUSH_SYNC);

in out_unlock.



-- 
-- Sujit K M

<Prev in Thread] Current Thread [Next in Thread>