xfs
[Top] [All Lists]

Re: [PATCH] xfs: update max log size

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: update max log size
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Mon, 11 May 2009 11:25:23 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20090511160609.GA18278@xxxxxxxxxxxxx>
References: <20090511160609.GA18278@xxxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.21 (X11/20090320)
Christoph Hellwig wrote:
> Commit a6634fba3dec4a92f0a2c4e30c80b634c0576ad5 in xfsprogs increased the
> maximum log size supported by mkfs.  Merged back the changes to xfs_fs.h
> so the growfs enforced the same limit and the headers are in sync.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Ok, looks like kernelspace only cares about this during
xfs_growfs_log_private(), and that's not actually implemented yet,
right?  So no worries about kernel<->userspace version correlation I think.

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxxx>

> Index: xfs/fs/xfs/xfs_fs.h
> ===================================================================
> --- xfs.orig/fs/xfs/xfs_fs.h  2009-02-08 21:51:06.576943974 +0100
> +++ xfs/fs/xfs/xfs_fs.h       2009-05-10 21:33:30.970822643 +0200
> @@ -239,10 +239,13 @@ typedef struct xfs_fsop_resblks {
>   * Minimum and maximum sizes need for growth checks
>   */
>  #define XFS_MIN_AG_BLOCKS    64
> -#define XFS_MIN_LOG_BLOCKS   512
> -#define XFS_MAX_LOG_BLOCKS   (64 * 1024)
> -#define XFS_MIN_LOG_BYTES    (256 * 1024)
> -#define XFS_MAX_LOG_BYTES    (128 * 1024 * 1024)
> +#define XFS_MIN_LOG_BLOCKS   512ULL
> +#define XFS_MAX_LOG_BLOCKS   (1024 * 1024ULL)
> +#define XFS_MIN_LOG_BYTES    (10 * 1024 * 1024ULL)
> +
> +/* keep the maximum size under 2^31 by a small amount */
> +#define XFS_MAX_LOG_BYTES \
> +     ((2 * 1024 * 1024 * 1024ULL) - XFS_MIN_LOG_BYTES)
>  
>  /*
>   * Structures for XFS_IOC_FSGROWFSDATA, XFS_IOC_FSGROWFSLOG & 
> XFS_IOC_FSGROWFSRT
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
> 

<Prev in Thread] Current Thread [Next in Thread>