xfs
[Top] [All Lists]

Re: [PATCH] xfs: fix double unlock in xfs_swap_extents()

To: Felix Blyakher <felixb@xxxxxxx>
Subject: Re: [PATCH] xfs: fix double unlock in xfs_swap_extents()
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 8 May 2009 02:28:19 -0400
Cc: xfs@xxxxxxxxxxx, kernel-testers@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, a.beregalov@xxxxxxxxx
In-reply-to: <1241745202-7452-1-git-send-email-felixb@xxxxxxx>
References: <1241745202-7452-1-git-send-email-felixb@xxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
The patch looks good, but a little nitpick:

On Thu, May 07, 2009 at 08:13:22PM -0500, Felix Blyakher wrote:
>  out:
>       kmem_free(tempifp);
>       return error;
>  
> +out_unlock:
> +     xfs_iunlock(ip,  XFS_ILOCK_EXCL | XFS_IOLOCK_EXCL);
> +     xfs_iunlock(tip, XFS_ILOCK_EXCL | XFS_IOLOCK_EXCL);
> +     goto out;
> +
>  out_trans_cancel:
>       xfs_trans_cancel(tp, 0);
>       goto out_unlock;

this would be more readable as:

 out_trans_cancel:
        xfs_trans_cancel(tp, 0);
 out_unlock:
        xfs_iunlock(ip,  XFS_ILOCK_EXCL | XFS_IOLOCK_EXCL);
        xfs_iunlock(tip, XFS_ILOCK_EXCL | XFS_IOLOCK_EXCL);
        goto out;

<Prev in Thread] Current Thread [Next in Thread>