[Top] [All Lists]

Re: [PATCH] xfs_repair: open filesystem device exclusively

To: xfs@xxxxxxxxxxx
Subject: Re: [PATCH] xfs_repair: open filesystem device exclusively
From: "Nathaniel W. Turner" <nate@xxxxxxxxxxxxxxx>
Date: Wed, 06 May 2009 22:46:20 -0400
In-reply-to: <20090316212332.GA8496@xxxxxxxxxxxxx>
References: <49B48B8E.3030602@xxxxxxxxxxxxxxx> <49B491EA.4090003@xxxxxxxxxxxxxxx> <20090316212332.GA8496@xxxxxxxxxxxxx>
User-agent: Thunderbird (X11/20090409)
...just a friendly reminder to look at this again now that 3.0.1 is out.

Christoph Hellwig wrote:
On Sun, Mar 08, 2009 at 11:50:02PM -0400, Nathaniel W. Turner wrote:
(Error messages could probably be improved to be more user-friendly in
this new failure case, and it probably wouldn't hurt to add a BLKROGET
ioctl to check for read-only block devices with read-write permissions,
but this does the job for me.)

Signed-off-by: Nathaniel W. Turner <nate@xxxxxxxxxxxxxxx>
 repair/init.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/repair/init.c b/repair/init.c
index 8e508c4..7e5052c 100644
--- a/repair/init.c
+++ b/repair/init.c
@@ -142,6 +142,8 @@ xfs_init(libxfs_init_t *args)
         args->isreadonly = (LIBXFS_ISREADONLY | LIBXFS_ISINACTIVE);
     else if (dangerously)
         args->isreadonly = (LIBXFS_ISINACTIVE | LIBXFS_DANGEROUSLY);
+    else
+        args->isreadonly = LIBXFS_EXCLUSIVELY;

Given that we skip it for -d and -n this is fine with me.

I think we might want to delay this change in the way xfs_repair
operates until after we get a 3.0.1 release out with all the build
system fixes (hopefully really soon)

xfs mailing list

Nathaniel W. Turner
<Prev in Thread] Current Thread [Next in Thread>