[Top] [All Lists]

Re: [PATCH] xfsdump: add .gitignore

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfsdump: add .gitignore
From: Bill Kendall <wkendall@xxxxxxx>
Date: Mon, 04 May 2009 09:54:19 -0500
Cc: Timothy Shimmin <timothy.shimmin@xxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20090504074021.GA29449@xxxxxxxxxxxxx>
References: <20090429135050.GC30808@xxxxxxxxxxxxx> <d38e348a0905031635s3b7a812cl3e46d13069572d97@xxxxxxxxxxxxxx> <20090504074021.GA29449@xxxxxxxxxxxxx>
User-agent: Thunderbird (X11/20090409)
Christoph Hellwig wrote:
On Mon, May 04, 2009 at 09:35:39AM +1000, Timothy Shimmin wrote:
Get rid of the symlinked files by creating a local library for the
commonality? ;-)Probably easier said than done - I haven't looked at the
code in a while - but I
I think the traditional library model is better than a heap of symlinks :)

It probably is.  I'll put it on my todo list..

Not sure how well if fits the library model, unfortunately. The
symlinked files need to be compiled for dump and then recompiled
for restore as there's a bunch of #ifdef DUMP and #ifdef RESTORE
sections. I guess two libraries could be created, if separate
build dirs were used under common.


<Prev in Thread] Current Thread [Next in Thread>