xfs
[Top] [All Lists]

Re: [PATCH] xfstests: enforce lazy-count=0 in log tests 018, 081, 082

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: enforce lazy-count=0 in log tests 018, 081, 082
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 23 Apr 2009 13:11:51 -0400
Cc: xfs mailing list <xfs@xxxxxxxxxxx>
In-reply-to: <49EE28EA.4010409@xxxxxxxxxxx>
References: <49EE28EA.4010409@xxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Tue, Apr 21, 2009 at 03:13:30PM -0500, Eric Sandeen wrote:
> I was experimenting w/ default lazy-count=1, and it broke a few tests.
> Seems simplest to enforce lazy-count=0 in the common.log routines
> for now, and fix up the output?  (vs. updating all the expected
> output for these tests...)

Didn't you just send a patch to make lazy-count=1 the default? :)

I'd rather see either a filter dealing with both variants or make
sure we always test the newer and more important case (lazy-count=1)
here.

<Prev in Thread] Current Thread [Next in Thread>