xfs
[Top] [All Lists]

Re: [PATCH] xfs: add more checks to superblock validation

To: Felix Blyakher <felixb@xxxxxxx>
Subject: Re: [PATCH] xfs: add more checks to superblock validation
From: "Josef 'Jeff' Sipek" <jeffpc@xxxxxxxxxxxxxx>
Date: Sun, 19 Apr 2009 14:14:10 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <81FBAD0F-AE2A-4780-BC8B-135C4CCE8D3A@xxxxxxx>
References: <1240002765-20279-1-git-send-email-felixb@xxxxxxx> <20090418050544.GQ3709@xxxxxxxxxxxxxx> <81FBAD0F-AE2A-4780-BC8B-135C4CCE8D3A@xxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Sun, Apr 19, 2009 at 11:39:20AM -0500, Felix Blyakher wrote:
>
> On Apr 18, 2009, at 12:05 AM, Josef 'Jeff' Sipek wrote:
>
>> On Fri, Apr 17, 2009 at 04:12:45PM -0500, Felix Blyakher wrote:
>>> From: Olaf Weber <olaf@xxxxxxx>
>>>
>>> There had been reports where xfs filesystem was randomly
>>> corrupted with fsfuzzer, and xfs failed to handle it
>>> gracefully. This patch fixes couple of reported problem
>>> by providing additional checks in the superblock
>>> validation routine.
>>>
>>> Signed-off-by: Felix Blyakher <felixb@xxxxxxx>
>>
>> Since this patch is from Olaf, shouldn't he have a s-o-b line as well?
>
> I was following the guidelines from the SubmittingPatches:
>
> The "from" line must be the very first line in the message body,
> and has the form:
>
>         From: Original Author <author@xxxxxxxxxxx>
>
> The "from" line specifies who will be credited as the author of the
> patch in the permanent changelog.  If the "from" line is missing,
> then the "From:" line from the email header will be used to determine
> the patch author in the changelog.
>
>
> So, is "From:" enough here, or "Signed-off-by" is needed as well?

The From line determines author-ship. If this is Olaf's patch, then the From
is right. My understanding is that s-o-b is intended as a "I didn't do
anything stupid (e.g., incorporate licensed code, etc.) while working on
this patch/handling this patch." This makes me believe that the author
should include a s-o-b line as well.

So, for example, whenever _I_ send a patch that I authored, I have both a
>From and a s-o-b. If someone picks it up (e.g., akpm), he'd add his s-o-b,
so when he resends it, it'd have my from, my s-o-b, and his s-o-b. As far as
I know, other kernel folks do the same.

Jeff.

-- 
My public GPG key can be found at
http://www.josefsipek.net/gpg/public-0xC7958FFE.txt

<Prev in Thread] Current Thread [Next in Thread>