xfs
[Top] [All Lists]

Re: [PATCH] xfstests: fix async io error handling in fsx

To: Felix Blyakher <felixb@xxxxxxx>
Subject: Re: [PATCH] xfstests: fix async io error handling in fsx
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 13 Apr 2009 09:58:34 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20090406163331.GA22240@xxxxxxxxxxxxx>
References: <1239031576-26279-1-git-send-email-felixb@xxxxxxx> <20090406163331.GA22240@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Mon, Apr 06, 2009 at 12:33:31PM -0400, Christoph Hellwig wrote:
> On Mon, Apr 06, 2009 at 10:26:16AM -0500, Felix Blyakher wrote:
> > The result of async io returned in the event.res in addition
> > to the number of bytes read/written provides negated error
> > number. The broken libaio defines event.res as unsigned
> > while the same structure in the kernel defines it as signed.
> > The kernel indeed treats it as signed, and returns the
> > negated error number. Till libaio is fixed we provide
> > the signed long temp var.
> > Also set errno for each error condition in aio_rw, as the
> > caller is not aio aware and expects ret(-1)+errno by the
> > traditional libc convention.
> 
> Looks good.
> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Do you plan to commit this?  Otherwise I'll just suck it into the
xfstests-dev tree.

<Prev in Thread] Current Thread [Next in Thread>